search

marzzzello / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies (fork)
GNU General Public License v3.0
270 stars 20 forks source link

Homebrew path fix on MacOS #38

Closed SemperPeritus closed 1 year ago

SemperPeritus commented 1 year ago

Fix for issue #29 Works on MacOS 16.2 (MacBook Pro with M1). mpv installed with brew. PATH contains homebrew path. Workaround in the issue.

SemperPeritus commented 1 year ago

@rucker Can you check is works in your environment? Compiled modified version here.

marzzzello commented 1 year ago

Thanks!

rucker commented 1 year ago

@SemperPeritus @marzzzello Sorry, I didn't get to this fast enough! This does in fact work for my setup (M1 Mac + Homebrew), however for this to be a more complete solution I think the script should be able to locate mpv and ffmpeg somewhat more flexibly by checking other possible locations:

  1. Homebrew: Homebrew's prefix differs between Intel Macs (/usr/local/) and Apple Silicon Macs (/opt/homebrew/) (Source)
  2. Without Homebrew: mpv.app could be installed at /Applications or ~/Applications (likely the former). The mpv binary itself lives here and Homebrew symlinks to it.

Since this is already merged, what I think I'll do is submit a PR to expand on @SemperPeritus's changes.