Open po5 opened 1 year ago
This does not solve the issue for me, the thumbnail has the correct aspect ratio, but the image is still glitched.
Here is the result with the video in https://github.com/marzzzello/mpv_thumbnail_script/issues/4#issuecomment-992027155.
Weird, can you try it in thumbfast with a compatible UI? We do the same thing there and it seems to work.
Let me know if the PR is badly implemented or if thumbfast's fix itself is not sufficient.
It works with thumbfast (vanilla osc).
I'm confused, also because the PR does fix the issue in some cases.
The "glitched" effect looks like the thumbnails are generated for the landscape video, but then to represent them the rows are wrapped around to match the portrait video width. This is indeed what happens with my test file if the thumbnails are generated before the video is rotated, then they are shown as alternating white/grey rows.
In any case, even if I'd like to investigate this further, it solves the issue sometimes and it's still a good enough reason to merge.
I was wrong, the test video I made created thumbnails that were too regular and hid the glitches. Here is another, the problem is still present:
Closes #4