search

marzzzello / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies (fork)
GNU General Public License v3.0
270 stars 20 forks source link

No OSC on new mpv-git #48

Closed vlnka closed 9 months ago

vlnka commented 9 months ago

Description of the bug No OSC or thumbnails appear when playing a video on mpv after a commit made between 2023-11-12 (7cab30c) and 2023-11-26 (6898d57). OSC works normally on shinchiro mpv build (recommended build for Windows as per https://mpv.io/installation/) based on mpv up to commit 7cab30c and doesn't work the build of mpv up to 6898d57 and later builds.

To Reproduce Steps to reproduce the behavior:

  1. Open any video in mpv
  2. No OSC when moving the cursor around

Expected behavior OSC appears together with thumbnails when cursor is moved around the screen

Debug log

Log ``` [ytdl_hook] Loading lua script @ytdl_hook.lua... [ytdl_hook] loading mp.defaults [mpv_thumbnail_script_client_osc] Loading lua script D:/Programs/mpv/scripts/mpv_thumbnail_script_client_osc.lua... [mpv_thumbnail_script_server] Loading lua script D:/Programs/mpv/scripts/mpv_thumbnail_script_server.lua... [mpv_thumbnail_script_client_osc] loading mp.defaults [mpv_thumbnail_script_server] loading mp.defaults [mpv_thumbnail_script_client_osc] loading file D:/Programs/mpv/scripts/mpv_thumbnail_script_client_osc.lua [ytdl_hook] loading @ytdl_hook.lua [mpv_thumbnail_script_server] loading file D:/Programs/mpv/scripts/mpv_thumbnail_script_server.lua [ytdl_hook] reading options for ytdl_hook [ytdl_hook] script-opts/ytdl_hook.conf not found. [ytdl_hook] lua-settings/ytdl_hook.conf not found. 'uname' is not recognized as an internal or external command, operable program or batch file. [mpv_thumbnail_script_client_osc] reading options for mpv_thumbnail_script [mpv_thumbnail_script_client_osc] Opened config file script-opts/mpv_thumbnail_script.conf. [mpv_thumbnail_script_client_osc] reading options for osc [mpv_thumbnail_script_client_osc] script-opts/osc.conf not found. [mpv_thumbnail_script_client_osc] lua-settings/osc.conf not found. [mpv_thumbnail_script_client_osc] [mpv_thumbnail_script_client_osc] stack traceback: [mpv_thumbnail_script_client_osc] D:/Programs/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4509: in main chunk [mpv_thumbnail_script_client_osc] [C]: at 0x7ff6b7201830 [mpv_thumbnail_script_client_osc] [C]: at 0x7ff6b7200f30 [mpv_thumbnail_script_client_osc] Lua error: D:/Programs/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4466: attempt to call field 'shared_script_property_set' (a nil value) [mpv_thumbnail_script_client_osc] Exiting... 'uname' is not recognized as an internal or external command, operable program or batch file. [mpv_thumbnail_script_server] reading options for mpv_thumbnail_script [mpv_thumbnail_script_server] Opened config file script-opts/mpv_thumbnail_script.conf. [ytdl_hook] ytdl:// hook [ytdl_hook] not a ytdl:// url [ytdl_hook] playlist hook (+) Video --vid=1 (*) (hevc 3840x2160 23.976fps) (+) Audio --aid=1 --alang=eng (*) 'TrueHD Atmos 7.1' (truehd 8ch 48000Hz) Audio --aid=2 --alang=eng 'AC-3 5.1' (ac3 6ch 48000Hz) Subs --sid=1 --slang=eng (f) 'English (Forced)' (hdmv_pgs_subtitle) Subs --sid=2 --slang=eng 'English' (hdmv_pgs_subtitle) Subs --sid=3 --slang=eng 'English (SDH) (UHD)' (hdmv_pgs_subtitle) Subs --sid=4 --slang=eng 'English (SDH) (BD)' (hdmv_pgs_subtitle) Subs --sid=5 --slang=ara 'Arabic' (hdmv_pgs_subtitle) Subs --sid=6 --slang=bul 'Bulgarian' (hdmv_pgs_subtitle) Subs --sid=7 --slang=chi 'Chinese (Cantonese)' (hdmv_pgs_subtitle) Subs --sid=8 --slang=chi 'Chinese (Mandarin Traditional)' (hdmv_pgs_subtitle) Subs --sid=9 --slang=hrv 'Croatian' (hdmv_pgs_subtitle) Subs --sid=10 --slang=cze 'Czech' (hdmv_pgs_subtitle) Subs --sid=11 --slang=dan 'Danish' (hdmv_pgs_subtitle) Subs --sid=12 --slang=dut 'Dutch' (hdmv_pgs_subtitle) Subs --sid=13 --slang=est 'Estonian' (hdmv_pgs_subtitle) Subs --sid=14 --slang=fin 'Finnish' (hdmv_pgs_subtitle) Subs --sid=15 --slang=fre 'French (Canadian)' (hdmv_pgs_subtitle) Subs --sid=16 --slang=fre 'French (Parisian)' (hdmv_pgs_subtitle) Subs --sid=17 --slang=ger 'German' (hdmv_pgs_subtitle) Subs --sid=18 --slang=ger 'German (SDH)' (hdmv_pgs_subtitle) Subs --sid=19 --slang=gre 'Greek' (hdmv_pgs_subtitle) Subs --sid=20 --slang=heb 'Hebrew' (hdmv_pgs_subtitle) Subs --sid=21 --slang=hin 'Hindi' (hdmv_pgs_subtitle) Subs --sid=22 --slang=hun 'Hungarian' (hdmv_pgs_subtitle) Subs --sid=23 --slang=ind 'Indonesian' (hdmv_pgs_subtitle) Subs --sid=24 --slang=ita 'Italian' (hdmv_pgs_subtitle) Subs --sid=25 --slang=kor 'Korean' (hdmv_pgs_subtitle) Subs --sid=26 --slang=may 'Malay' (hdmv_pgs_subtitle) Subs --sid=27 --slang=nor 'Norwegian' (hdmv_pgs_subtitle) Subs --sid=28 --slang=pol 'Polish' (hdmv_pgs_subtitle) Subs --sid=29 --slang=por 'Portuguese (Brazilian)' (hdmv_pgs_subtitle) Subs --sid=30 --slang=por 'Portuguese (Iberian)' (hdmv_pgs_subtitle) Subs --sid=31 --slang=rus 'Russian' (hdmv_pgs_subtitle) Subs --sid=32 --slang=spa 'Spanish (Castilian)' (hdmv_pgs_subtitle) Subs --sid=33 --slang=spa 'Spanish (Latin American)' (hdmv_pgs_subtitle) Subs --sid=34 --slang=swe 'Swedish' (hdmv_pgs_subtitle) Subs --sid=35 --slang=tha 'Thai' (hdmv_pgs_subtitle) Subs --sid=36 --slang=tur 'Turkish' (hdmv_pgs_subtitle) Subs --sid=37 --slang=ukr 'Ukrainian' (hdmv_pgs_subtitle) Subs --sid=38 --slang=vie 'Vietnamese' (hdmv_pgs_subtitle) File tags: Title: Pearl (2022) [mpv_thumbnail_script_server] Announcing self to master... [file] Cannot open file 'auto': No such file or directory Failed to open auto. Using hardware decoding (d3d11va). [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [ao/wasapi] No suitable audio format found AO: [openal] 44100Hz stereo 2ch float [mpv_thumbnail_script_server] Announcing self to master... VO: [gpu-next] 3840x2160 d3d11[p010] [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Thumbnail worker registering timed out AV: 00:00:08 / 01:41:58 (0%) A-V: -0.002 DS: 6/2 ```

Environment

vlnka commented 9 months ago

I have found out that mpv-git 7cab30c run from console says "The shared-script-properties property is deprecated and will be removed in the future. Use the user-data property instead." which corresponds to the part of the script that failed (see log).

vlnka commented 9 months ago

I'll open a new issue with more specific findings