marzzzello / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies (fork)
GNU General Public License v3.0
270 stars 20 forks source link

Thumbnail previews broken in latest version of mpv #54

Closed 3k2 closed 3 months ago

3k2 commented 4 months ago

Description of the bug A clear and concise description of what the bug is. Thumbnails aren't loading anymore I guess it has something to do with latest mpv version perhaps?

To Reproduce Steps to reproduce the behavior:

  1. Go to try play any video
  2. Ran the command clicked video to play or commandline doesn't matter fails.
  3. See error

Expected behavior Expected to see seekbar and thumbnail previews in the video

Debug log Run mpv with mpv --msg-level=mpv_thumbnail_script_server=debug,mpv_thumbnail_script_client_osc=debug

Log ``` ➜ mpv --msg-level=mpv_thumbnail_script_server=debug,mpv_thumbnail_script_client_osc=debug /home/ntldr/JAY\ 𓃦\ 🔜\ FC\ ☀️\ -\ How\ the\ FUCK\ did\ they\ put\ this\ shit\ in\ like\ ultra\ 4K\ HD,\ why\ does\ it\ look\ so\ good??\ 😳\ \[1614465171946369029\].mp4 [mpv_thumbnail_script_server] Loading lua script /etc/mpv/scripts/mpv_thumbnail_script_server.lua... [mpv_thumbnail_script_client_osc] Loading lua script /etc/mpv/scripts/mpv_thumbnail_script_client_osc.lua... [mpv_thumbnail_script_server] loading mp.defaults [mpv_thumbnail_script_client_osc] loading mp.defaults [mpv_thumbnail_script_client_osc] loading file /etc/mpv/scripts/mpv_thumbnail_script_client_osc.lua [mpv_thumbnail_script_server] loading file /etc/mpv/scripts/mpv_thumbnail_script_server.lua [mpv_thumbnail_script_server] reading options for mpv_thumbnail_script [mpv_thumbnail_script_server] Opened config file script-opts/mpv_thumbnail_script.conf. [mpv_thumbnail_script_client_osc] reading options for mpv_thumbnail_script [mpv_thumbnail_script_client_osc] Opened config file script-opts/mpv_thumbnail_script.conf. [mpv_thumbnail_script_client_osc] reading options for osc [mpv_thumbnail_script_client_osc] script-opts/osc.conf not found. [mpv_thumbnail_script_client_osc] lua-settings/osc.conf not found. [mpv_thumbnail_script_client_osc2] [mpv_thumbnail_script_client_osc2] stack traceback: [mpv_thumbnail_script_client_osc2] .../.config/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4465: in main chunk [mpv_thumbnail_script_client_osc2] [C]: at 0x62a10410da70 [mpv_thumbnail_script_client_osc2] [C]: at 0x62a10410e120 [mpv_thumbnail_script_client_osc2] Lua error: .../.config/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4424: attempt to call field 'shared_script_property_set' (a nil value) [mpv_thumbnail_script_client_osc] [mpv_thumbnail_script_client_osc] stack traceback: [mpv_thumbnail_script_client_osc] /etc/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4465: in main chunk [mpv_thumbnail_script_client_osc] [C]: at 0x62a10410da70 [mpv_thumbnail_script_client_osc] [C]: at 0x62a10410e120 [mpv_thumbnail_script_client_osc] Lua error: /etc/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4424: attempt to call field 'shared_script_property_set' (a nil value) [mpv_thumbnail_script_client_osc] Exiting... (+) Video --vid=1 (*) (h264 1024x576 54.682fps) (+) Audio --aid=1 (*) (aac 2ch 44100Hz) [mpv_thumbnail_script_server] Announcing self to master... AO: [pulse] 44100Hz stereo 2ch float VO: [gpu] 1024x576 yuv420p [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Announcing self to master... [mpv_thumbnail_script_server] Thumbnail worker registering timed out [mpv_thumbnail_script_server2] Thumbnail worker registering timed out Exiting... (Quit) [mpv_thumbnail_script_server] Exiting... ```

Environment

Additional context Add any other context about the problem here.

(1:0.38.0-2 => 1:0.37.0-3) I downgraded my package to that one and thumbnails are working correctly. After updating to the latest version they stop working.

davidhealey commented 3 months ago

Same issue here on Debian testing

marzzzello commented 3 months ago

Should be fixed with the new v0.5.4 release