MBEDTLS3 - Githubissues

mas-bandwidth / yojimbo

A network library for client/server games written in C++

BSD 3-Clause "New" or "Revised" License

2.45k stars 238 forks source link

MBEDTLS3 #158

Closed onehundredfeet closed 2 years ago

onehundredfeet commented 2 years ago

Updated to MBEDTLS3.

Added define to switch back and forth (Current default is to MBEDTLS3 which loses backwards compatibility)
Removed reference to two retired headers
Removed reference to default certificate
Added certificate as a parameter to the matcher
Added matcher hostname and port as parameters rather than compiled constants

jorgenpt commented 2 years ago

How does this pull request differ from https://github.com/networkprotocol/yojimbo/pull/153? Just maintaining back compat and not upgrading the in-tree version? What is the benefit of leaving mbedtls 2.x compat?

Green-Sky commented 2 years ago

Added certificate as a parameter to the matcher

Added matcher hostname and port as parameters rather than compiled constants

I think those changes would still be beneficial.

jorgenpt commented 2 years ago

Ok -- might be good to split that pull request out from an upgrade of mbedtls.

Looks like the other PR got merged yesterday, so this'll need rebasing / merging.

gafferongames commented 2 years ago

Can somebody please rebase/merge this, or close this PR?

onehundredfeet commented 2 years ago

Sure. I'll update it.