search

mas-bandwidth / yojimbo

A network library for client/server games written in C++
BSD 3-Clause "New" or "Revised" License
2.45k stars 238 forks source link

Ability to specify matcher certificate & address #169

Closed onehundredfeet closed 8 months ago

onehundredfeet commented 2 years ago

Added the ability to specify a parameter for the certificate on the matcher logic. Added the ability to specify the address and port for the matcher.

Previously MBEDTLS3 #158

gafferongames commented 2 years ago

Matcher is really not meant to be used in production code? It's just sort of an example...

gafferongames commented 2 years ago

I would expect that most people write their own matcher, in a high level language, like golang, or node js in the backend...

onehundredfeet commented 2 years ago

Understood, and I agree, however it's provided in the core yojimbo.cpp and not an example, so the code would be included (and likely stripped) in any production build.

I'd recommend splitting out the matcher functionality from the yojimbo.cpp if it's not expected to be production ready. However, it's the only way of using the 'connectToken' approach.

I have just been the matcher you provided as a way of proving out the connection token code path. I felt like the modifications in this pull request made the library more development friendly even if a final shippable version would likely be modified.

gafferongames commented 2 years ago

OK I'll take a look at it

gafferongames commented 8 months ago

Hi folks, I have actually removed the matcher entirely from the latest version of Yojimbo. It really doesn't belong with the core library, and it creates a dependency on mbedtls, which ultimately, forces the usage of a very large library on the user, who may not even want to use that for https!