m_sentPackets sequence fix & some other minor changes

mas-bandwidth / yojimbo

A network library for client/server games written in C++

BSD 3-Clause "New" or "Revised" License

2.45k stars 238 forks source link

m_sentPackets sequence fix & some other minor changes #171

Closed jorgenpt closed 8 months ago

jorgenpt commented 2 years ago

Fix the assert that triggers if you only intermittently send reliable messages
Clean up the acked field which isn't being used

jorgenpt commented 2 years ago

Not sure why this is failing on macOS, I'll investigate.

jorgenpt commented 2 years ago

Huh. It ran fine when it was re-run, and I wasn't able to reproduce.

JoeCreoterra commented 2 years ago

@gafferongames whenever you have time I'd love to hear your thoughts on this PR. It looks like a great fix to get rid of having to send dummy reliable packets to avoid the issue, but was curious as to what you think.

gafferongames commented 2 years ago

I'm concerned around the heisenbug on tests. Please run locally on MacOS and loop the tests (while true). If it's an intermittent timing related test failure, then this approach usually catches it.

gafferongames commented 8 months ago

I believe this has been fixed in another PR. If I'm wrong, please let me know.