When running some tests I noticed that the YojimboClient would sometimes sets its state to CLIENT_STATE_CONNECTED before the server would execute the OnServerClientConnected callback. Looking at the current logic the YojimboClient sets the state to CLIENT_STATE_CONNECTED when the netcode state is NETCODE_CLIENT_STATE_SENDING_CONNECTION_RESPONSE rather than when it is NETCODE_CLIENT_STATE_CONNECTED.
gafferongames
commented
1 year ago
When running some tests I noticed that the
YojimboClientwould sometimes sets its state toCLIENT_STATE_CONNECTEDbefore the server would execute theOnServerClientConnectedcallback. Looking at the current logic theYojimboClientsets the state toCLIENT_STATE_CONNECTEDwhen the netcode state isNETCODE_CLIENT_STATE_SENDING_CONNECTION_RESPONSErather than when it isNETCODE_CLIENT_STATE_CONNECTED.This PR fixes that.