🐛 [BUG] Certain Items Returned from Search Results with Negative ID

[hao-lh]

Your Environment

• mas version: 1.8.6
• macOS version (system_profiler SPSoftwareDataType -detailLevel mini): System Version: macOS 10.15.7 (19H2) Kernel Version: Darwin 19.6.0 Time since boot: 1:30

mas Install Method

• [x] brew install mas (homebrew-core)
• [] mas-cli/tap
• [] .pkg installer from releases
• [] Built from source
  • Fork/branch: ? (e.g. mas-cli/main)
  • Xcode version: 10.?

Describe the Bug

When use keyword with mas to search apps, some items returned with a negative MAS ID.

To Reproduce

Steps to reproduce the behavior:

1. mas search xcode
2. some items from search results returned a negative ID
3. already highlighted details from below screenshot
4. should be type overflow

Screenshots, Terminal Output

[bjesuiter]

I have the same problem with "Lockera Widgets".

mas search "Lockera Widgets" returns -2123114745 Lockera Widgets (1.6)

and trying to install this with mas "Lockera Widgets", id: -2123114745 fails.

[voodooGQ]

Having the same issue with "iBar" showing up as -2146090692 iBar-Menubar icon control tool (1.2.4)

[tvlieg]

I have the same with "Noteshelf 3": -2131199389 Noteshelf 3 (1.4.8)

[jandamm]

Same here for StopTheMadness Pro and Keymapp.

Seems like the InstallOptions need an Int instead of UInt64: https://github.com/mas-cli/mas/blob/763392cb23359064b14b0a099b62f050c093b2df/Sources/MasKit/Commands/Install.swift#L54

[deed02392]

I think it's the other way around @jandamm – we want UInt64 throughout Search: https://github.com/mas-cli/mas/blob/main/Sources/MasKit/Controllers/MasStoreSearch.swift#L15

edit: it's mainly an output/formatting bug, fixed in: https://github.com/mas-cli/mas/pull/479 – UInt64 would still be a more proper type though