Refactor ProtocolStaking smart contract

masa-finance / masa-oracle

Masa Oracle: Decentralized Data Protocol 🌐

https://developers.masa.ai/docs/category/oracle-node

MIT License

16 stars 14 forks source link

Refactor ProtocolStaking smart contract #324

Closed Luka-Loncar closed 3 months ago

Luka-Loncar commented 3 months ago

Refactor the OracleNodeStaking contract to achieve better code organization, reusability, and maintainability, rename it to ProtocolStaking to reflect our updated code and vision. Reference: https://github.com/masa-finance/masa-oracle/issues/317

Add rescue() functions to the staking smart contract
Add pausable interface to the staking smart contract
Add reentrancy guards to the staking smart contract
Add admin user to the staking smart contract
Add deployment scripts
Deploy to Sepolia

TODO

The information regarding stakes must be tracked and recorded over time, as they are subject to change. This will affect the calculation of rewards.
Investigate this in ticket #329

Luka-Loncar commented 3 months ago

@miquelcabot can you pls put into the ticket the solution you used for this contract?

miquelcabot commented 3 months ago

Solved in https://github.com/masa-finance/masa-contracts-oracle/pull/117

teslashibe commented 3 months ago

@miquelcabot @H34D can you update the descriptoon to include a summary of what was implemented and create a list of any outstanding tasks that require new tickets. I am reopening the issue and moving this back to QA until the description has been added to the ticket and any next steps have been ticketed out.

cc @Luka-Loncar @mudler

miquelcabot commented 3 months ago

@miquelcabot @H34D can you update the descriptoon to include a summary of what was implemented and create a list of any outstanding tasks that require new tickets. I am reopening the issue and moving this back to QA until the description has been added to the ticket and any next steps have been ticketed out.

cc @Luka-Loncar @mudler

@teslashibe Done!