Closed mcamou closed 1 week ago
Attention: Patch coverage is 18.39080%
with 71 lines
in your changes missing coverage. Please review.
Project coverage is 12.76%. Comparing base (
5d12c5e
) to head (a705d53
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was having trouble with some tests after moving the Options processing to Config, so I'm going step by step. The first commit is JUST removing the singleton.
Description
After #623, #625 and #626, this is the final cleanup step. Our code is now singleton-free, and the circular dependencies that prevented us from moving Options processing to the
config
package are no more.Notes for Reviewers
Die, singletons, die!!!!!
Signed commits