masa-finance / masa-oracle

Masa Oracle: Decentralized Data Protocol 🌐
https://developers.masa.ai/docs/masa-protocol/welcome
MIT License
24 stars 19 forks source link

chore(cleanup): Finish removing the AppConfig singleton and move Options processing to the config package #630

Closed mcamou closed 1 week ago

mcamou commented 1 week ago

Description

After #623, #625 and #626, this is the final cleanup step. Our code is now singleton-free, and the circular dependencies that prevented us from moving Options processing to the config package are no more.

Notes for Reviewers

Die, singletons, die!!!!!

Signed commits

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 18.39080% with 71 lines in your changes missing coverage. Please review.

Project coverage is 12.76%. Comparing base (5d12c5e) to head (a705d53). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
node/options.go 0.00% 24 Missing :warning:
pkg/config/app.go 0.00% 20 Missing :warning:
cmd/masa-node/main.go 0.00% 12 Missing :warning:
node/oracle_node_listener.go 0.00% 6 Missing :warning:
node/oracle_node.go 0.00% 4 Missing :warning:
pkg/workers/types/work_types.go 0.00% 2 Missing :warning:
node/protocol.go 0.00% 1 Missing :warning:
pkg/pubsub/manager.go 50.00% 1 Missing :warning:
pkg/workers/worker_manager.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #630 +/- ## ========================================== + Coverage 10.92% 12.76% +1.83% ========================================== Files 93 93 Lines 6708 6739 +31 ========================================== + Hits 733 860 +127 + Misses 5894 5804 -90 + Partials 81 75 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mcamou commented 1 week ago

I was having trouble with some tests after moving the Options processing to Config, so I'm going step by step. The first commit is JUST removing the singleton.