masa-iwasaki / setup-rbenv

Set up your GitHub Actions workflow with rbenv
MIT License
16 stars 3 forks source link

Warnings during execution #7

Open matsev opened 3 years ago

matsev commented 3 years ago

The set-env and add-path commands were deprecated the other week. Consequently, two warnings are generated when GitHub Actions execute masa-iwasaki/setup-rbenv@1.2.0. Please follow the instructions at Setting an environment variable and Adding a system path respectively to avoid those warnings.

Copied from the output:

Run masa-iwasaki/setup-rbenv@1.2.0
sudo git clone --depth 1 https://github.com/rbenv/rbenv.git /home/runner/.rbenv
Cloning into '/home/runner/.rbenv'...
[...]
sudo chown -R runner /home/runner/.rbenv
Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Version: 1.2.0

masa-iwasaki commented 3 years ago

@matsev I recommend to use ruby/setup-ruby for existing users of setup-rbenv. ruby/setup-ruby as I wrote in README. This actions supports various versions of Ruby for most of platforms supported by GitHub Actions. However, I am also interested in if there is any usecase which requires setup-rbenv.

matsev commented 3 years ago

@masa-iwasaki Thanks for the feedback, I'll take a look at ruby/setup-ruby. It was some time since I configured my GitHub Action to use your tool so when I noticed a new warning during execution I thought I'd better report it. In hindsight, I should have looked more closely at the readme since it has clearly been updated since after my original configuration.