masa-su / pixyz

A library for developing deep generative models in a more concise, intuitive and extendable way
https://pixyz.io
MIT License
491 stars 41 forks source link

Fix/unupdated x dict #115

Closed ktaaaki closed 4 years ago

ktaaaki commented 4 years ago

This is fix of IterativeLoss. (hot fix #114 is closed.)

Issue: a bug of IterativeLoss

  1. x_dict.update({value: x_dict[key]}) at line:156 register key-variable's value as value-variable's value. And key-variable remains.
  2. At next step, key-variable are sometimes overwritten but sometimes not. For example, AddLoss copies an input dictionary, and overwrite old one to updated one.
  3. the key-variable is not updated. So the effect of reccurence is ignored.

Solution