narray fail to build in windows with mingw tool

masa16 / narray

This repository contains OLD version of NArray. Please visit NEW version =>

https://github.com/ruby-numo/numo-narray

168 stars 28 forks source link

narray fail to build in windows with mingw tool #2

Closed sgwong closed 13 years ago

sgwong commented 13 years ago

The Makefile generate with current extconf.rb file not able to build in Windows with mingw tool. The following modification will make it build and install in windows with mingw.(tested in Windows 7 64 bit ruby 1.9.2)

@@ -54,7 +54,7 @@

 if /cygwin|mingw/ =~ RUBY_PLATFORM
   if RUBY_VERSION > '1.8.0'
-    $DLDFLAGS << ",--out-implib=libnarray.a"
+    $DLDFLAGS << " -Wl,--out-implib=libnarray.a"
   elsif RUBY_VERSION > '1.8'
     CONFIG["DLDFLAGS"] << ",--out-implib=libnarray.a"
     system("touch libnarray.a")

masa16 commented 13 years ago

Thank you for the patch. This is fixed at the branch head.