search

masahiro331 / go-ext4-filesystem

Apache License 2.0
7 stars 10 forks source link

fix(ext4): replaced filepath.Separator with "/" #3

Closed SoftPoison closed 1 year ago

SoftPoison commented 1 year ago

This fixes an inconsistency when the library is used on Windows.

On Linux, the file path separator is "/", but on Windows it is "\". As "/" is already hardcoded elsewhere, and "/" is a forbidden character in file names and folders on Windows already, all instances have been replaced with "/".

Closes #2

masahiro331 commented 1 year ago

Oh!!!! I appreciate the PR.

I'll review it.

masahiro331 commented 1 year ago

@SoftPoison Thank you !!!

SoftPoison commented 1 year ago

Thanks for merging! :)

masahiro331 commented 1 year ago

If you don't mind, here too. 👨 https://github.com/masahiro331/go-xfs-filesystem

SoftPoison commented 1 year ago

Sure thing! :)

https://github.com/masahiro331/go-xfs-filesystem/pull/2