feat: Add deploy script

masajid / deployment

0 stars 0 forks source link

feat: Add deploy script #1

Closed dosht closed 4 years ago

dosht commented 4 years ago

TODO:

[x] Split k8s.yaml to multiple file
[x] Support local deployment (e.g. to Minikube)
[x] Fix configMapRef and test

dosht commented 4 years ago

I get an error related to configMapRef when I try to build with Kustomize:

kustomize build local
2019/11/09 23:08:46 nil value at `configMapRef.name` ignored in mutation attempt
2019/11/09 23:08:46 nil value at `configMapRef.name` ignored in mutation attempt
2019/11/09 23:08:46 nil value at `configMapRef.name` ignored in mutation attempt

mgharbik commented 4 years ago

@dosht somehow configMapRef.name needs 2 tabs indent, I honestly don't know why.

By the way envFrom is a redundant key we can get rid of it and use arrays.

dosht commented 4 years ago

Let's maintain a consistent yaml files with the same order of apiVersion, kind, meta and specs

@EslamElHusseiny I couldn't understand from the documentation which version we should use.

EslamElHusseiny commented 4 years ago

@dosht which version?

dosht commented 4 years ago

I understood wrong. You only talked about ordering. I thought you want also to have the same apiVersion for all resources. 👍

dosht commented 4 years ago

@EslamElHusseiny I updated the PR. Please recheck.

EslamElHusseiny commented 4 years ago

@dosht base/masajid/deployment.yaml is missing

dosht commented 4 years ago

@EslamElHusseiny Done