masakudamatsu / line-height-picker

A front-end web app that helps web designers/developers pick the best line-height value for their websites
https://line-height-picker.vercel.app
MIT License
2 stars 1 forks source link

Deal with useEffect warnings #251

Open masakudamatsu opened 3 years ago

masakudamatsu commented 3 years ago

Currently, loading any page will show the following warnings in the console:

./src/components/Page.js
  Line 11:6:  React Hook useEffect has missing dependencies: 'props.meta.content', 'props.meta.name', and 'props.title'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
./src/components/ScrollToTop.js
  Line 15:6:  React Hook useEffect has a missing dependency: 'history'. Either include it or remove the dependency array  react-hooks/exhaustive-deps