masakudamatsu / mima

My Ideal Map, a web app to allow users to save places with **external links** on Google Maps
https://www.my-ideal-map.app
MIT License
1 stars 0 forks source link

Fine-tune ripple effects to indicate the user's clicking #216

Open masakudamatsu opened 2 years ago

masakudamatsu commented 2 years ago

NOTE: This issue will be redundant if we solve issue #108 with the ripple blowing away the popup.

Problem

Currently, the ripple effect is not noticeable enough for

possible solutions for autocomplete suggestions

possible solutions for close button

masakudamatsu commented 1 year ago

If we set a very long animation duration like 2000ms, we do see the ripple effect.

But it's not clear what duration is the best.

We also need to coordinate the ripple animation with the transition animation. For the search box, the duration of animation for the ripple effect (600ms set in ButtonCircle.js) is not coordinated with that for closing the search box (duration.modal.exit used in Search.js).

Setting both to be 250ms, however, won't allow us to notice the ripple as the search box disappears quickly.