masakudamatsu / mima

My Ideal Map, a web app to allow users to save places with **external links** on Google Maps
https://www.my-ideal-map.app
MIT License
1 stars 0 forks source link

Enable failed Lighthouse assertions #57

Open masakudamatsu opened 3 years ago

masakudamatsu commented 3 years ago

Edit lighthouserc.js to enable failed assertions one by one, to implement the best practices suggested by Lighthouse.

Reference

https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/getting-started.md#add-assertions

To get back to passing, inspect the log output of the build and disable the audits that failed. Treat this as a burndown list of your team of issues to fix!

The audit log before disabling the assertions (Oct 7 2021)

9 result(s) for http://localhost:34465/404.html :

  ✘  apple-touch-icon failure for minScore assertion
       Does not provide a valid `apple-touch-icon`
       https://web.dev/apple-touch-icon/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  csp-xss failure for minScore assertion
       Ensure CSP is effective against XSS attacks
       https://web.dev/strict-csp/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  installable-manifest failure for minScore assertion
       Web app manifest or service worker do not meet the installability requirements
       https://web.dev/installable-manifest/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  maskable-icon failure for minScore assertion
       Manifest doesn't have a maskable icon
       https://web.dev/maskable-icon-audit/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  meta-description failure for minScore assertion
       Document does not have a meta description
       https://web.dev/meta-description/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  service-worker failure for minScore assertion
       Does not register a service worker that controls page and `start_url`
       https://web.dev/service-worker/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  splash-screen failure for minScore assertion
       Is not configured for a custom splash screen
       https://web.dev/splash-screen/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  themed-omnibox failure for minScore assertion
       Does not set a theme color for the address bar.
       https://web.dev/themed-omnibox/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ⚠️  legacy-javascript warning for maxLength assertion
       Avoid serving legacy JavaScript to modern browsers

        expected: <=0
           found: 1
      all values: 1, 1, 1

20 result(s) for http://localhost:34465/index.html :

  ✘  apple-touch-icon failure for minScore assertion
       Does not provide a valid `apple-touch-icon`
       https://web.dev/apple-touch-icon/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  csp-xss failure for minScore assertion
       Ensure CSP is effective against XSS attacks
       https://web.dev/strict-csp/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  font-display failure for minScore assertion
       Ensure text remains visible during webfont load
       https://web.dev/font-display/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  image-size-responsive failure for minScore assertion
       Serves images with low resolution
       https://web.dev/serve-responsive-images/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  installable-manifest failure for minScore assertion
       Web app manifest or service worker do not meet the installability requirements
       https://web.dev/installable-manifest/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  maskable-icon failure for minScore assertion
       Manifest doesn't have a maskable icon
       https://web.dev/maskable-icon-audit/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  preload-lcp-image failure for minScore assertion
       Preload Largest Contentful Paint image
       https://web.dev/optimize-lcp/#preload-important-resources

        expected: >=0.9
           found: 0.45
      all values: 0.43, 0.45, 0.45

  ✘  service-worker failure for minScore assertion
       Does not register a service worker that controls page and `start_url`
       https://web.dev/service-worker/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  splash-screen failure for minScore assertion
       Is not configured for a custom splash screen
       https://web.dev/splash-screen/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  tap-targets failure for minScore assertion
       Tap targets are not sized appropriately
       https://web.dev/tap-targets/

        expected: >=0.9
           found: 0.76
      all values: 0.76, 0.76, 0.76

  ✘  themed-omnibox failure for minScore assertion
       Does not set a theme color for the address bar.
       https://web.dev/themed-omnibox/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  unused-javascript failure for maxLength assertion
       Reduce unused JavaScript
       https://web.dev/unused-javascript/

        expected: <=0
           found: 1
      all values: 1, 1, 1

  ✘  uses-passive-event-listeners failure for minScore assertion
       Does not use passive listeners to improve scrolling performance
       https://web.dev/uses-passive-event-listeners/

        expected: >=0.9
           found: 0
      all values: 0, 0, 0

  ✘  uses-rel-preconnect failure for maxLength assertion
       Preconnect to required origins
       https://web.dev/uses-rel-preconnect/

        expected: <=0
           found: 2
      all values: 2, 2, 2

  ✘  uses-text-compression failure for maxLength assertion
       Enable text compression
       https://web.dev/uses-text-compression/

        expected: <=0
           found: 4
      all values: 4, 4, 4

  ⚠️  interactive warning for minScore assertion
       Time to Interactive
       https://web.dev/interactive/

        expected: >=0.9
           found: 0.69
      all values: 0.64, 0.69, 0.69

  ⚠️  largest-contentful-paint warning for minScore assertion
       Largest Contentful Paint
       https://web.dev/lighthouse-largest-contentful-paint/

        expected: >=0.9
           found: 0.08
      all values: 0.06, 0.07, 0.08

  ⚠️  legacy-javascript warning for maxLength assertion
       Avoid serving legacy JavaScript to modern browsers

        expected: <=0
           found: 1
      all values: 1, 1, 1

  ⚠️  speed-index warning for minScore assertion
       Speed Index
       https://web.dev/speed-index/

        expected: >=0.9
           found: 0.87
      all values: 0.8, 0.87, 0.84

  ⚠️  uses-long-cache-ttl warning for maxLength assertion
       Serve static assets with an efficient cache policy
       https://web.dev/uses-long-cache-ttl/

        expected: <=0
           found: 1
      all values: 1, 1, 1
masakudamatsu commented 1 year ago

This is relevant for landing page.