masalinas / node-red-contrib-talib

TA-Lib nodes for node-RED
Apache License 2.0
3 stars 2 forks source link

EMA don't have input value #6

Open willyk0 opened 2 years ago

willyk0 commented 2 years ago

Hi. First of all, my apologies for breaking all possible rules in github for opening an issue. I'm not a programmer, I don't know how git works, I don't know how to make a ptach, but I found an issue and wanted to give my 2 cents. So please don't kill me for this :)

EMA don't have an input label where you can enter the period calculated so it always does 30. The parameter at the input is also ignored.

I found the HTML is this:


<!-- Exponential Moving Average: EMA -->
<script type="text/x-red" data-template-name="EMA">
  <div class="form-row">
    <label for="node-input-name"><i class="fa "></i> Name</label>
    <input type="text" id="node-input-name">
  </div>
</script>

and watching the code for other indicators like DEMA (which works) I copypasted those 4 lines and worked.


<!-- Exponential Moving Average: EMA -->
<script type="text/x-red" data-template-name="EMA">
  <div class="form-row">
    <label for="node-input-name"><i class="fa "></i> Name</label>
    <input type="text" id="node-input-name">
  </div>
  <div class="form-row">
    <label for="node-input-optInTimePeriod"><i class="fa "></i> Time Period</label>
    <input type="text" id="node-input-optInTimePeriod" placeholder="Number of period">
  </div>
</script>

Best regards and thank you for bringing this awesome library :)