search

masamichiueta / FluidPhoto

Fluid photo viewer with zoom transition and interactive transition
MIT License
296 stars 25 forks source link

Push will have problems #12

Open gaohomway opened 5 years ago

gaohomway commented 5 years ago

Push will have problems, Have you noticed? It should be a problem with the agent.

1555568203724

masamichiueta commented 5 years ago

What do you mean? Can you attach a gif?

gaohomway commented 5 years ago

Recorded a video that you can download and watch.

masamichiueta commented 5 years ago

Ah, I understand. Thanks, I will check it.

gaohomway commented 5 years ago

@masamichiueta Thank you very much for sharing this library.

But I am very difficult to use, especially when it comes to integration. The photo transition should be a public library, but your business logic for this intrusion. I think it is a structural problem, I think the structure should be：

Grid：【UICollectionView】-【UICollectionViewCell】-【UIImageView】-【Click event】-> Browse：【UICollectionView】-【UICollectionViewCell】-【UIScrollView】-【UIImageView】

This is the structure I think is ideal. UICollectionView instead of UIPageViewController and UIViewController. what do you think?

masamichiueta commented 5 years ago

@weifans Thanks for your feedback! Yes, I'm also considering that using UICollectionView may be better.

I will refactor this project later.

gaohomway commented 5 years ago

@masamichiueta I haven't seen you for a long time. I have been busy recently. Is there an upgrade plan?

masamichiueta commented 5 years ago

@weifans Sorry, I'm working another project now, and refactoring priority is low now.