masamitsu-murase / redmine_add_subversion_links

Add links to open TortoiseSVN automatically.
11 stars 4 forks source link

Conflict with code review plugin #2

Closed jwalkerbg closed 12 years ago

jwalkerbg commented 12 years ago

Hi,

I tried to view an issue, created by code review plugin before installing redmine_add_subversion_links plugin. This returned me an error, here is the log:

========= log start ========= Processing IssuesController#show (for 192.168.2.100 at 2011-12-09 21:08:41) [GET] Parameters: {"action"=>"show", "id"=>"50", "controller"=>"issues"} Rendering template within layouts/base Rendering issues/show

ActionView::TemplateError (undefined method `revision' for "229":String) on line #45 of app/views/issues/show.html.erb: 42: <% end %> 43: 44: <%= render_custom_fields_rows(@issue) %> 45: <%= call_hook(:view_issues_show_details_bottom, :issue => @issue) %> 46: 47: 48: <% if @issue.description? || @issue.attachments.any? -%>

lib/redmine/hook.rb:63:in `send'
lib/redmine/hook.rb:63:in `call_hook'
lib/redmine/hook.rb:63:in `each'
lib/redmine/hook.rb:63:in `call_hook'
lib/redmine/hook.rb:60:in `tap'
lib/redmine/hook.rb:60:in `call_hook'
lib/redmine/hook.rb:144:in `call_hook'
app/views/issues/show.html.erb:45
app/controllers/issues_controller.rb:127:in `show'
app/controllers/issues_controller.rb:126:in `show'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/httpserver.rb:104:in `service'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/httpserver.rb:65:in `run'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:173:in `start_thread'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:162:in `start'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:162:in `start_thread'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:95:in `start'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:92:in `each'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:92:in `start'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:23:in `start'
d:/Program Files/Ruby/lib/ruby/1.8/webrick/server.rb:82:in `start'

Rendering D:/biz/apps/redmine_trunk/public/500.html (500 Internal Server Error) ========= log end =========

Issues created by Code review plugins contain references to repository revisions (ex.: http://localhost:3000/projects/first/repository/revisions/229). Normal issues are opened successfully.

The code review page is at http://www.redmine.org/plugins/codereview, http://www.r-labs.org/projects/r-labs/wiki/Code_Review_en

Regards

masamitsu-murase commented 12 years ago

Hi. Thank you for your report again!

Your error log is very helpful for me. Thank you so much.

I will release a fixed version in this weekend, and then I will release a new version which supports peg revision in several weeks.

Regards

masamitsu-murase commented 12 years ago

I released a fixed version 0.0.2 and confirmed compatibility with Redmine 1.3.0. Please refer to http://www.redmine.org/plugins/add_subversion_links.

Regards, Murase