Closed ryuji-hashimoto0110 closed 5 months ago
Attention: Patch coverage is 97.43590%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 99.54%. Comparing base (
e71f357
) to head (f7505cd
).:exclamation: Current head f7505cd differs from pull request most recent head 9f6361e. Consider uploading reports for the commit 9f6361e to get more accurate results
Files | Patch % | Lines |
---|---|---|
pams/market.py | 87.50% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
log.read_and_writeをfor文で回すのは筋が悪いので、bulk_read_ane_writeを作ろうと思います。
こっちは意外と対処がむずいので、一旦置いておくことにします。loggerを直接触ればいいという説もあるのですが、それをすると、log側で書き込み時にhookすることが難しくなるので、ちょっと用検討です。(hookが必要なシーンというのは実際問題ないのですが...)
ExpirationLog
inlogs.base
.Logger.process_expiration_log
method.OrderBook._check_expired_orders()
andOrderBook._set_time()
have been changed to return a list of expiration logs.Market._set_time()
andMarket._update_time()
have been changed to read and write expiration logs internally.