masanorihirano / pams

PAMS: Platform for Artificial Market Simulations
https://pams.hirano.dev
Eclipse Public License 1.0
41 stars 5 forks source link

add expiration logs #99

Closed ryuji-hashimoto0110 closed 5 months ago

ryuji-hashimoto0110 commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.54%. Comparing base (e71f357) to head (f7505cd).

:exclamation: Current head f7505cd differs from pull request most recent head 9f6361e. Consider uploading reports for the commit 9f6361e to get more accurate results

Files Patch % Lines
pams/market.py 87.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== - Coverage 99.57% 99.54% -0.03% ========================================== Files 76 76 Lines 5819 5890 +71 ========================================== + Hits 5794 5863 +69 - Misses 25 27 +2 ``` | [Flag](https://app.codecov.io/gh/masanorihirano/pams/pull/99/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Masanori+HIRANO) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/masanorihirano/pams/pull/99/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Masanori+HIRANO) | `99.54% <97.43%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Masanori+HIRANO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

masanorihirano commented 5 months ago
masanorihirano commented 5 months ago

log.read_and_writeをfor文で回すのは筋が悪いので、bulk_read_ane_writeを作ろうと思います。

こっちは意外と対処がむずいので、一旦置いておくことにします。loggerを直接触ればいいという説もあるのですが、それをすると、log側で書き込み時にhookすることが難しくなるので、ちょっと用検討です。(hookが必要なシーンというのは実際問題ないのですが...)