masasam / emacs-easy-hugo

Emacs major mode for managing hugo
https://gohugo.io/tools/editors/#emacs
GNU General Public License v3.0
362 stars 26 forks source link

easy-hugo-open-config #20

Closed cescoferraro closed 7 years ago

masasam commented 7 years ago

Hi @cescoferraro

Please rebase to the latest master.

Because there is a possibility that it will be published to melpa when merging master.

Let's erase "D ... Dired" and put "c ... Open config".

Please adjust tab and blank to other files.

masasam commented 7 years ago

Hi @cescoferraro

In this case it is better to write in cond rather than if.

like ..

(cond ((eq easy-hugo--current-blog 1) (easy-hugo-1)) ((eq easy-hugo--current-blog 2) (easy-hugo-2)) ((eq easy-hugo--current-blog 3) (easy-hugo-3)) ((eq easy-hugo--current-blog 4) (easy-hugo-4)) ((eq easy-hugo--current-blog 5) (easy-hugo-5)) ((eq easy-hugo--current-blog 6) (easy-hugo-6)) ((eq easy-hugo--current-blog 7) (easy-hugo-7)) ((eq easy-hugo--current-blog 8) (easy-hugo-8)) ((eq easy-hugo--current-blog 9) (easy-hugo-9)) ((eq easy-hugo--current-blog 0) (easy-hugo-0))))

masasam commented 7 years ago

Thanks. It is nice.

Let's change message function to error function.

Please rebase to the latest master.

Look at the latest master "defconst easy-hugo-help".

It is different from your "defconst easy-hugo-help".

masasam commented 7 years ago

Hi @cescoferraro

585 (t (message "There is no Hugo config file inside your easy-hugo-basedir"))))

easy-hugo-basedir is easy to understand by displaying the actual user's directory.

masasam commented 7 years ago

Hi @cescoferraro

Great jobs! Thank you for Pull Request.