masasron / adonis-throttle

A rate limiter for Adonis JS
MIT License
64 stars 11 forks source link

Extensible cache driver framework #9

Closed AndrewJo closed 5 years ago

AndrewJo commented 5 years ago

This PR adds ability for users to extend adonis-throttle by providing custom cache drivers. Redis driver is included as a reference implementation. This PR should not break any backwards-compatibility and the minor version can be bumped as per SEMVER 2.0 specification.

Changes

masasron commented 5 years ago

Thank you @AndrewJo, great work! 👍

AndrewJo commented 5 years ago

Thank you @AndrewJo, great work! 👍

You're welcome @masasron! I decided to write it after I realized that this provider doesn't consistently rate limit requests if I horizontally scale AdonisJs in Docker containers.

Please let me know when you plan on releasing v2.2.0 on npm.

Also, what are your plans for CI/CD for this package? I can help set up an automated release pipeline so that a new version tag would trigger a new npm release if you're interested.

masasron commented 5 years ago

@AndrewJo that would be great, let's talk

AndrewJo commented 5 years ago

@masasron sounds good. I'll create a new issue. Let's move our conversation there.