masastack / MASA.Blazor.Pro

Material design admin template for blazor.
http://blazor-pro.masastack.com/
MIT License
242 stars 57 forks source link

Add rounded style on navigation component. #176

Closed CuteLeon closed 1 year ago

CuteLeon commented 1 year ago

Description

Add rounded-r-xl style on navigation component.

Issue reference

null

Checklist

doddgu commented 1 year ago

Thanks for your PR. Please provide the rounded navigation screenshot. This will improve the review efficiency. And why you set it rounded? We designed a outer border for it.

CuteLeon commented 1 year ago

image image

Hi @doddgu , screenshot attached. This improvement is used to make the style of navigation component more uniform with other components.

doddgu commented 1 year ago

@CuteLeon Hi, flat is by design. If you like rounded, you can add a settings for it.

CuteLeon commented 1 year ago

Hi, @doddgu, I Implemented a NavigationStyle config to control navigation bar style. And kept default option as current Flat approach. image

capdiem commented 1 year ago

@CuteLeon Indent 8 spaces?

CuteLeon commented 1 year ago

My IDE replaced white-space characters automatically, I have reverted them;

@CuteLeon Indent 8 spaces?

pccai commented 1 year ago

Online Demo cannot setting rounded style?

capdiem commented 1 year ago

@pccai let me check

capdiem commented 1 year ago

@pccai Updated.