search

masbug / flysystem-google-drive-ext

Flysystem adapter for Google Drive with seamless virtual<=>display path translation
Other
222 stars 62 forks source link

Exceptions are discarded #133

Open tobias-kuendig opened 1 month ago

tobias-kuendig commented 1 month ago

Exceptions are discarded in many places of the Google Drive Adapter:

https://github.com/masbug/flysystem-google-drive-ext/blob/b2ed8b530ef6ae55a1a8f2ee2d6e779ae98e2d97/src/GoogleDriveAdapter.php#L469

In this example, we lose all context of why the upload failed (in my case, a full Google Drive). This context should not simply be discarded but passed along with the actual error.

fredsal commented 1 month ago

Hi, feel free to open a PR with the fix using UnableToWriteFile class with more descriptive message https://github.com/masbug/flysystem-google-drive-ext/blob/b2ed8b530ef6ae55a1a8f2ee2d6e779ae98e2d97/src/GoogleDriveAdapter.php#L468-L473