search

maschmann / TranslationLoaderBundle

Symfony2 bundle with database translation loader
23 stars 9 forks source link

Parameters from orm.xml moved to the TreeBuilder #36

Closed qbarbosa closed 8 years ago

xabbuh commented 8 years ago

@quentinsikana Thanks for this PR. The changes look valid to (we should probably get rid of the class parameters in a future release, but that's nothing we can change right now). Can you also update the tests so that they pass again? Adding another test case that makes sure that we can actually change the parameters through the config would be great.

qbarbosa commented 8 years ago

@xabbuh Sure! But I must confess I'm still not familiar with Symfony2 testing. Could you give me an idea on how to do this?

qbarbosa commented 8 years ago

@xabbuh Old tests are now passing and I added a new one as you suggested.

qbarbosa commented 8 years ago

Everything looks fine, let's merge? :)

xabbuh commented 8 years ago

Thank you @quentinsikana. I have squashed your changes during merging. That's why your pull request is shown as closed instead of merged. I also added an entry to the changelog in ec515fb2a3c0b273f2e3e6e0e15ce2b2a11f2c3d. Thanks for your contribution!