Closed xabbuh closed 10 years ago
The code is now finished. I'll add the missing PHPdoc comments and some tests.
One thing I didn't change yet is the translation history. I thought about removing the TranslationHistorySubscriber
class and instead inject the TranslationHistoryManager
into the TranslationManager
when the history feature is enabled. This way the TranslationManager
could handle the history generation. Furthermore, that would make it independent from the real database layer. What do you think @maschmann?
I think this is ready for merge. Propel, CouchDB and MongoDB support can be added later on.
Here the error from the merge: http://pbrd.co/JVUn25
see #10
The missing @
before the service id should have been enough. I removed the newly added service definition for asm_translation_loader.translation_manager
and added a first which ensures that the services are created properly with an empty config.
This pull requests addresses #4
TODOs: