masciugo / genealogy

Make ActiveRecord model act as a pedigree
MIT License
30 stars 17 forks source link

How to support Unknown Gender as sex value. #21

Open mukeshsinghr opened 5 years ago

mukeshsinghr commented 5 years ago

Hi @masciugo,

I have the fixed the previous my issues my own. They are working :)

I wanted to support the use case where I can have gender as Unknown - U as value.

Is it possible ? I am trying to do so but getting many things to change. Still facing issues. This is kind of very important for me to solve at this stage. Can you please help and let me know the possibility.

Thanks, Mukesh

masciugo commented 5 years ago

Hi

I am afraid this is too expensive at moment for me. However I, in general I understand the needs to manage unknown gender or even different kind of family for what concerns parents' sexuality as already pointed out by @jasonfb here

mukeshsinghr commented 5 years ago

Hi Corrado,

I understand your point of view. I too don't want to put more hurdles to you. I am already on the way to include unknown gender. Is it possible for you to help me or at least guide me some extent so I can solve this. I have seen many checks are in place for gender basis check in genealogy relations.

Thanks, Mukesh

masciugo commented 5 years ago

Hi sorry for the delay but as I said I am really busy. Of course gender is heavily connected to many functionalities, I'd suggest to adopt TDD approach. So fork the this project add some tests about the new gender value and see what get broken. Start from model_settings_spec.rb then alter the sample tree used in spec adding someone with unknown gender and add tests to query_methods_spec.rb. Then add tests to **alter_*** methods

mukeshsinghr commented 5 years ago

Thanks @masciugo, This will help me get on. I will check accordingly.

scriptmonkey commented 5 years ago

@mukeshsinghr have you made any progress towards this issue? I am aslo dealing with needing an other for my needs.

mukeshsinghr commented 5 years ago

Hi @scriptmonkey , I have handled it in my application layer, so I didn't modify the genealogy gem.