search

masecla22 / Reddit4J

A library which aims to attain full coverage of the Reddit API
MIT License
48 stars 21 forks source link

Subreddit Posts Support #4

Closed FRKJ closed 2 years ago

masecla22 commented 2 years ago

Looks very good thus far!

Arnuh commented 2 years ago

Personally not a huge fan of Reddit4J class holding so much. In my eyes it should just be a helper to get to other classes that have those methods.

Not related but an example is /me stuff would be under a specific class and only is accessible while doing a user connect. Downside being if an API request is required for the initial creation of the class holding the methods like Subreddit

FRKJ commented 2 years ago

Discovered an issue where large API responses get truncated due to JSoup's default 2MB body limit, just setting this to unlimited will solve the problem.

masecla22 commented 2 years ago

:)

Arnuh commented 2 years ago

Looks like /api/info wasn't added to covered endpoints from the last commit