masenga01 / aeroquad

Automatically exported from code.google.com/p/aeroquad
0 stars 0 forks source link

Single byte on the serial line sets motors to full power #123

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The calibrate command '1' sets all motors to full power. A problem with the 
serial line or an xbee is enough to get serious wounds, see 
http://aeroquad.com/showthread.php?3394-safety-feature-request-motor-command-aut
hentication
Change the protocol for the most dangerous commands 1-5, e.g. by adding a non 
trivial keyword and repeating the command, e.g. '1CaLiBrAte1' instead of the 
blood hungry single byte '1'.
This also requires a configurator change.

Original issue reported on code.google.com by al...@arcor.de on 28 Jun 2011 at 12:49

GoogleCodeExporter commented 9 years ago
I'll post in the provide link to discuss how to add in additional safety.  
Thanks!

Original comment by CaranchoEngineering@gmail.com on 24 Jul 2011 at 10:21

GoogleCodeExporter commented 9 years ago

Original comment by CaranchoEngineering@gmail.com on 24 Jul 2011 at 10:21

GoogleCodeExporter commented 9 years ago
Would it be enough to perform a ask for a specific float like "123.45" to 
validate that a full throttle cal is being sent?

Original comment by CaranchoEngineering@gmail.com on 25 Jul 2011 at 6:51

GoogleCodeExporter commented 9 years ago
Yes, just send a parameter value you can read with readFloatSerial and check 
it, but it could be a bit more random than 123.45 :)

Original comment by al...@arcor.de on 25 Jul 2011 at 10:28

GoogleCodeExporter commented 9 years ago
Heh heh, I think I like 123.45 because it's very specific and shouldn't be an 
accidental value misinterpreted by accident.  Thanks for the catch, this was a 
very good thing to lock down.

Implemented, still needs test.

Original comment by CaranchoEngineering@gmail.com on 26 Jul 2011 at 6:24