search

masesgroup / KNet

KNet is a comprehensive .NET suite for Apache Kafka™ providing all features: Producer, Consumer, Admin, Streams, Connect, backends (ZooKeeper and Kafka).
https://knet.masesgroup.com/
Apache License 2.0
33 stars 6 forks source link

PR #426 contains code updates on KNet Connect SDK shall be tested #427

Open masesdevelopers opened 4 months ago

masesdevelopers commented 4 months ago 
          This PR contains changes on KNet Connect SDK that can introduce bugs: make a test on it to verify compatibility.

Originally posted by @masesdevelopers in https://github.com/masesgroup/KNet/issues/426#issuecomment-1972087844

masesdevelopers commented 4 months ago

The code of https://github.com/masesgroup/KNet/blob/9bf7012a0561bf7642a68157c53684a851dfcaed/src/net/KNet/Specific/Connect/KNetSinkTask.cs#L44 can be optimized returning an IEnumerable<SinkRecord> managed from a specific class able to use Prefetch which prepares SinkRecords while the user code uses them.

masesdevelopers commented 4 months ago

Tests will be postponed after #429 will be closed: updates and verification will be done with latest Apache Kafka version