Properties become methods to be aligned with other iterators - Githubissues

masesgroup / KNet

KNet is a comprehensive .NET suite for Apache Kafka™ providing all features: Producer, Consumer, Admin, Streams, Connect, backends (ZooKeeper and Kafka).

https://knet.masesgroup.com/

Apache License 2.0

32 stars 6 forks source link

Properties become methods to be aligned with other iterators #522

Closed masesdevelopers closed 4 days ago

masesdevelopers commented 4 days ago

Description

Properties becomes methods to be aligned with other iterators

Related Issue

fix #92

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

masesdevelopers commented 4 days ago

This lines are wrong: https://github.com/masesgroup/KNet/blob/71df6f59f7ceda6d48065fa45dc22cfd9191937e/src/net/KNet/Specific/Streams/State/TimestampedKeyValueIterator.cs#L144 https://github.com/masesgroup/KNet/blob/71df6f59f7ceda6d48065fa45dc22cfd9191937e/src/net/KNet/Specific/Streams/State/TimestampedKeyValueIterator.cs#L148 https://github.com/masesgroup/KNet/blob/71df6f59f7ceda6d48065fa45dc22cfd9191937e/src/net/KNet/Specific/Streams/State/TimestampedKeyValueIterator.cs#L179