masesgroup / netdroid

Android suite for .NET
https://netdroid.masesgroup.com/
Apache License 2.0
2 stars 1 forks source link

Try to use shared classes from JNet instead to copy them #76

Closed masesdevelopers closed 1 month ago

masesdevelopers commented 3 months ago

68 contains changes manually copied from JNet. Maybe the shared classes shall be available in a common repository to avoid possible errors during the copy.

Originally posted by @masesdevelopers in https://github.com/masesgroup/netdroid/issues/2#issuecomment-2271472003

masesdevelopers commented 3 months ago

Two options were identified:

masesdevelopers commented 3 months ago

Two options were identified:

* **submodule**:

  * link JNet repository with a submodule
  * remove copied classes and link them to the submodule folder
  * for JVM side the best way is to create symlinks otherwise, from current knowledge, Maven is not able to compile classes outside pom.xml subfolders

The previous option in any case do not guarantee that changes on JNet side are completely available because, in case of new classes, the Netdroid project shall be reviewed to check if something is missing.

* **request a change to JNet**: maybe JNet project, instead to have all classes in the same folder, can create different folders

  * one, ore more, folders with the common classes: containing, at least, the classes JNetReflector expects to be available
  * other folders with remaining classes specific to the project

The previous needs a request to be opened on JNet project.

masesdevelopers commented 1 month ago

84 closes the issue, however there are two main problems with build: