Add better formatting, use mainly numpy functions for math, and add more comments to ODE block.

masfaraud / BMSpy

Python Block-Model Simulator. An alternative to simulink in python.

GNU Lesser General Public License v3.0

222 stars 36 forks source link

Add better formatting, use mainly numpy functions for math, and add more comments to ODE block. #14

Closed ericonr closed 6 years ago

ericonr commented 6 years ago

By making the code compliant to PEP8, it is easier to read and make sense of;
Using mainly numpy makes the code more uniform;
It would be nice to explain the ODE function even more, because it seems powerful but it is hard to understand what it's doing.

ericonr commented 6 years ago

I'm thinking about making the FunctionBlock able to take more than one input, as well.

masfaraud commented 6 years ago

Hi, It seems that you forked from an old version, can you merge your branch from the current master and make a new pull request? As you changed a lot of things with the PEP8 syntax, merging will make the code regress.

ericonr commented 6 years ago

I couldn't find any new commits on your master branch... Your last commits are from Mar 1

masfaraud commented 6 years ago

Sorry, I didn't check well the code. The pull request is now merged!