search

mashephe / AmpTools

A utility library for performing amplitude analysis on particle physics data.
20 stars 12 forks source link

Some minor fixes for the Dalitz tutorial #105

Closed bgrube closed 2 years ago

mashephe commented 2 years ago

Hi Boris,

As an alternative to your change to printAmplitudes.cc could you try this:

remove the resetSource call that you added.

On line 58 change:

AmpToolsInterface ATI(cfgInfo);

to

AmpToolsInterface ATI( cfgInfo, AmpToolsInterface::kPlotGeneration );

I think this will avoid creation of normalization integral interface and then the reset is not needed. This should be much more efficient if one wants to print a few amplitudes.

Thanks again for checking these things. This "bug" was introduced when the NI interface was restructured a few months ago. This moved the data read calls to the constructor and caused the issue you noticed.

Matt

On Aug 11, 2022, at 7:29 PM, Boris Grube @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/mashephe/AmpTools/pull/105

Commit Summary

• e60c462 fix crash caused by using a dataReader instance that is already exhausted by the calculation of the normalization integrals • bfd6742 prevent creation of empty histograms for the kBkgnd data type • 3fea6f9 remove text that mentions non-existent DataWriter base class File Changes (4 files) • M Tutorials/Dalitz/DalitzExe/plotResults.cc (1) • M Tutorials/Dalitz/DalitzExe/printAmplitudes.cc (1) • M Tutorials/Dalitz/doc/doc.pdf (0) • M Tutorials/Dalitz/doc/doc.tex (4) Patch Links:

• https://github.com/mashephe/AmpTools/pull/105.patch • https://github.com/mashephe/AmpTools/pull/105.diff — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

bgrube commented 2 years ago

Hi Matt,

thanks for the hint! Changing the option, with which the AmpToolsInterface is constructed, is a much better approach. It prevents not only the unnecessary creation of the normalization integral interface but also that of the Minuit interface.