search

mashupbots / socko

A Scala web server powered by Netty networking and AKKA processing.
Other
255 stars 51 forks source link

Return 400 Bad Request when "Host" header is null #105

Open tkellogg opened 9 years ago

tkellogg commented 9 years ago

Fixes #102

veebs commented 9 years ago

Thanks Tim

I'll process it over the Christmas break.

Sorry, just been flat chat at work

Thanks again, Vibul

On 12 December 2014 at 10:50, Tim Kellogg notifications@github.com wrote:

Fixes #102 https://github.com/mashupbots/socko/issues/102

You can merge this Pull Request by running

git pull https://github.com/tkellogg/socko issue-102

Or view, comment on, or merge it at:

https://github.com/mashupbots/socko/pull/105 Commit Summary

  • Return 400 Bad Request when "Host" header is null

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/mashupbots/socko/pull/105.

malibuworkcrew commented 9 years ago

@veebs This looks good to me. We have been seeing failures when hit with HTTP/1.0 which does not require host header. This leads to connections not getting responses, timing out, and holding onto threads which eventually can kill servers hosting socko.