mashupbots / socko

A Scala web server powered by Netty networking and AKKA processing.
Other
255 stars 51 forks source link

Shutdown netty worker threads on WebServer.stop() #106

Closed mbarton closed 7 years ago

mbarton commented 9 years ago

My application was not stopping after WebServer.stop() was called. The netty event loop threads were staying alive.

Based on the Netty examples (http://netty.io/wiki/user-guide-for-4.x.html) I've changed stop() to shutdown the event loop groups.

I'm brand new to Netty and Socko so it is quite possible that this is by design but I've opened the pull request anyway.