Case-insensitive comparison of UPGRADE header

mashupbots / socko

A Scala web server powered by Netty networking and AKKA processing.

Other

255 stars 51 forks source link

Case-insensitive comparison of UPGRADE header #22

Closed ghost closed 12 years ago

ghost commented 12 years ago

Hello! We've encountered a problem when pattern matching in case client sends header like "Upgrade: WebSocket" The commit offers the solution (I'm quite new to github so I'm not sure if it's OK to commit to your master branch. Hope it's OK)

veebs commented 12 years ago

Thanks for this :-) We'll merge it.

Can I ask which client are you using that sends you "WebSocket"? It is my understanding that RFC 6455 requires "websocket".

ghost commented 12 years ago

We tried to use WCS, which took its "WebSocket" from Netty's HttpHeaders Since WCS and Socko apparently failed to understand each other, we adapted your test WebSocket client (no surprise it works) as a temporary solution. Thanks a lot for your work! =)

veebs commented 12 years ago

No problems. Appreciate you helping out with the pull request.