search

maskarade / gradle-android-ribbonizer-plugin

Modifies launcher icons on debug build
https://bintray.com/gfx/maven/ribbonizer-plugin
MIT License
355 stars 37 forks source link

Custom Text on Ribbon #12

Closed srolemberg closed 7 years ago

srolemberg commented 8 years ago

custom interface and implementation for manual setting of the text that appears on the ribbon.

srolemberg commented 8 years ago

Hello, I tried to simulate the problem, but did not understand the error message. Apparently I made the interface implementations correctly, just adding another way for the methods 'xxxRibbonFilter' receiving a 'String' as a parameter, but the gradle can not but find the 'builder ()' method.

gfx commented 8 years ago

Sorry to be late.

The idea looks good but CI fails. Can you pass the CI?

mensly commented 7 years ago

I was able to achieve this functionality without modifying the plugin code:

if (variant.flavorName == "qa") {
    def filter = yellowRibbonFilter(variant, iconFile)
    filter.label = "QA" + variant.versionCode
    return filter
}
srolemberg commented 7 years ago

Hello! As @mensly said, it is possible to do without modifying the plugin.

I no longer see the need for this implementation.

Thank you for your attention. And congratulations on the work. The tool is very useful.

gfx commented 7 years ago

Okay, thanks.