search

maskarade / gradle-android-ribbonizer-plugin

Modifies launcher icons on debug build
https://bintray.com/gfx/maven/ribbonizer-plugin
MIT License
355 stars 37 forks source link

[WANTED] A new maintainer #21

Closed gfx closed 7 years ago

gfx commented 7 years ago

There are lots of rooms to improve, but I have no time to do.

I have loved this project, but I am no longer working on the Android platform. It's happy if the project gets more maintainers who love this plugin.

beylerian commented 7 years ago

Oh that's too bad. I was wondering, will you stop maintaining Orma as well? Was just starting to use it.

gfx commented 7 years ago

No, I don't stop maintaining Orma, but I can't maintain everything of my Android projects.

mensly commented 7 years ago

I am interested if I can get approved to work on this during work hours, since we use this for a number of projects. Might have a crack at fixing a few issues before committing, though, as I haven't been a maintainer for any open source projects before

gfx commented 7 years ago

@mensly Thank you for your offer. As you suggested, we should make some works together at first. Can you make some pull-requests to the repo? I'll review them.

BTW I have created a new org to have some my Android projects: maskarade, and transferred the repo to it. I believe this is the best way to maintain OSS with teams.

mensly commented 7 years ago

Great, I'll try to look at a couple issues during this week.

gfx commented 7 years ago

Perfect. Thanks!

mensly commented 7 years ago

I've submitted three pull requests. Fixing two minor issues and allowing a workaround for the current major issue I logged.

What is the process for getting a new version out to everyone with these changes?

gfx commented 7 years ago

@mensly The pull-requests seem excellent. I have nothing to say 👍

Now you are invited as a collaborator. Check out: https://github.com/maskarade/gradle-android-ribbonizer-plugin/invitations

And can you tell me your bintray account? I'll invite you to https://bintray.com/ribbonizer too.

mensly commented 7 years ago

Perfect, was able to merge in that pull request that had a conflict.

Just created a bintray account with the same username, https://bintray.com/mensly

mensly commented 7 years ago

Once you've added me to bintray and that last PR is merged in, shall I send through the next build to bintray? Just ./gradlew bumpMinor, add some notes to CHANGES.md and make publish, right?

gfx commented 7 years ago

@mensly Congrats! And thanks, you are now a maintainer of the repo.

Once you've added me to bintray and that last PR is merged in, shall I send through the next build to bintray? Just ./gradlew bumpMinor, add some notes to CHANGES.md and make publish, right?

Perfect.

There is one thing you must to do in the first time you upload artifacts: after make publish, request link to jcenter from the bintray website and wait a few hours.

mensly commented 7 years ago

It looks like I am missing the permission to create a maven repository in the ribbonizer organisation.

mensly commented 7 years ago

Managed to have a successful publish to my personal profile on bintray, not realising it would automatically tag and push. Think I managed to undo the damage, but it does look like the only thing that's missing is the configuration on the org repos.

Execution failed for task ':plugin:bintrayUpload'.
> Could not create package 'ribbonizer/maven/ribbonizer-plugin': HTTP/1.1 404 Not Found [message:Repo 'maven' was not found]
gfx commented 7 years ago

Oh, sorry! I have changed your role on the bintray ribbonizer org. Can you try it again please?

mensly commented 7 years ago

Perfect, thanks. Now uploaded to https://bintray.com/ribbonizer/maven/ribbonizer-plugin

I've also submitting the request to push out to jcenter. I guess we can call this issue closed now? 😄

gfx commented 7 years ago

Yey! 🎉

Now the issue is completed ✅