confused about iconNames

[pellyadolfo]

Hi, I open this issue basically to ask for some explanation about your examples.

I tried to include ribbonizer in my project but nothing happens, no even errors. As a basic example, I did 3 things:

• 1. adding classpath 'com.github.gfx.ribbonizer:plugin:0.4.0' to the project's build.gradle
• 2. adding apply plugin: 'com.github.gfx.ribbonizer' to the module's build.gradle
• 3. adding to the module's build.gradle ribbonizer { builder { variant, iconFile -> return greenRibbonFilter(variant, iconFile) } }

I did not add any iconNames as I would expect it would take the declared in my AplicationManifest.as you comment in your example:

// "manifest application[android:icon]" is automatically added to the list

The result is that nothing happens, no errors and normal app icon.

So I wonder what I am doing wrong. I see in your example declared iconNames

iconNames "@drawable/ic_notification", "@drawable/widget_preview"

but I am not able to find these files your the project resources. So I wonder if they are created on the fly.

Could you please assess with that?

Thanks

[aluxian]

You need to add debuggable in your flavour/buildType config. I added it in debug: android.buildTypes.debug.debuggable true.

https://github.com/gfx/gradle-android-ribbonizer-plugin/blob/master/plugin/src/main/groovy/com/github/gfx/ribbonizer/plugin/RibbonizerPlugin.groovy#L50

[aluxian]

And iconNames, I believe, is an array with the drawables you want the ribbon to be added to. E.g. you might want to add a ribbon to your notification icon not just the launcher icon.

[mensly]

I think this has been resolved since the issue has raised, with more detailed example in the README.

Please raise a new issue if there is still some confusion.