search

maslianok / react-resize-detector

A Cross-Browser, Event-based, Element Resize Detection for React
http://maslianok.github.io/react-resize-detector/
MIT License
1.25k stars 91 forks source link

Move @type to dev dependency #202

Closed wallzero closed 2 years ago

wallzero commented 2 years ago

@type's should remain in dev dependencies. My multi repo project throws Cannot find name 'DOMRectReadOnly' because those packages aren't using "lib": ["DOM"] in their tsconfig.json.

peetjvv commented 2 years ago

Could you update the version of the @types/resize-observer-browser package as well please? The latest version (0.1.7) contains a fix for a type error that is picked up by the latest version of typescript (4.6.2).

Moving the @types package to dev deps will also fix the issue we experienced with the types since it will no longer be installed on our side, but I'm sure the issue will still prop up while maintaining this package.

benquarmby commented 2 years ago

@maslianok: Multiple TypeScript packages I'm close to are hitting the same issue that's fixed by this PR. Can you please take a look?

maslianok commented 2 years ago

Thank you, everyone! We have some problems here in Ukraine, but I hope everything will be fine in the nearest future, so I can continue work on my OS projects :)

maslianok commented 2 years ago

merged and deployed in v7.1.1