search

maslovakat / epam_fe_2019_maslova

Apache License 2.0
0 stars 0 forks source link

HW 9 #10

Open zheleznov opened 5 years ago

zheleznov commented 5 years ago

Hi Kate. First part of comments for HW9

Home Page

  1. Menu items is not left active when I click on it

  2. Disabled buttons shouldn't change on hover. Secondary button should be transparent btns

  3. As a tip you can use mailto attribute for email link

  4. Some issues with resizing on different resolutions resize 320 320-2

  5. This header lines looks slighty different as in design. There is no left and right small lines lines

  6. It's better to use input type submit form button in message form. and don't forget method attribute. Type submit will allow automaticaly send form data to backend to url from action form attribute via method

zheleznov commented 5 years ago

Some updates:

  1. Links in last post section doesn't have hover effect
  2. Social icons are also links - so they should have links and hover effect
zheleznov commented 4 years ago

Second Part

  1. Some issues with 320px resolution. For example this area doesn't look good posts 320

  2. search results shouldn't push down page content search

  3. Doesn't notice eralier, footer. It shouldn't be fixed. Just always placed at the bottom of the page

  4. Disabled buttons. Good that state is not changes on hover, but I still see cursor change from arrow to hand