search

maslovakat / epam_fe_2019_maslova

Apache License 2.0
0 stars 0 forks source link

HW3-CSS #4

Open zheleznov opened 5 years ago

zheleznov commented 5 years ago

Hi Kate :) I have checked HW3-CSS

Task 1. Calendar

  1. Calendar for block name is better that calendar-section. Block name should describe the block
  2. Two element name in one tag, and element of element for calendar-section__week__day can't be used in BEM
  3. Modifiers can't be used alone withou block name or element. https://en.bem.info/methodology/quick-start/#modifier Снимок2
  4. It's a bad idea to combine classes and tags in a select. In correct BEM structure CSS should be plained Снимок3 https://en.bem.info/methodology/css/#selectors

Task 2. Social Icons Good job here

Task 3. Forms

  1. Same issues with alone modifiers for inputs and element of element. Examples: Снимок4 Снимок5
  2. Select with the same options
  3. Label for select is missed
maslovakat commented 5 years ago

Hi, I understand about BEM, thanks for your feedback

вс, 27 окт. 2019 г., 22:59 Roman Zhelieznov notifications@github.com:

Hi Kate :) I have checked HW3-CSS

Task 1. Calendar

  1. Calendar for block name is better that calendar-section. Block name should describe the block
  2. Two element name in one tag, and element of element for calendar-sectionweekday can't be used in BEM
  3. Modifiers can't be used alone withou block name or element. https://en.bem.info/methodology/quick-start/#modifier http://url [image: Снимок2] https://user-images.githubusercontent.com/3533737/67641081-bcd9fa00-f907-11e9-89ca-2fd34c85c7e1.PNG
  4. It's a bad idea to combine classes and tags in a select. In correct BEM structure CSS should be plained [image: Снимок3] https://user-images.githubusercontent.com/3533737/67641105-180bec80-f908-11e9-913e-f2fb3d29c153.PNG https://en.bem.info/methodology/css/#selectors http://url

Task 2. Social Icons Good job here

Task 3. Forms

1.

Same issues with alone modifiers for inputs and element of element. Examples: [image: Снимок4] https://user-images.githubusercontent.com/3533737/67641679-9bc7d800-f90c-11e9-8282-b483a78c730e.PNG [image: Снимок5] https://user-images.githubusercontent.com/3533737/67641745-3de7c000-f90d-11e9-99e5-519d4ed410b3.PNG 2.

Select with the same options

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maslovakat/epam_fe_2019_maslova/issues/4?email_source=notifications&email_token=AEDZKLF336WQFZO4OXZKCS3QQXXLPA5CNFSM4JFTMWQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUUCV3Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZKLG76FQKOVKXAHXD463QQXXLPANCNFSM4JFTMWQA .