search

maslovakat / epam_fe_2019_maslova

Apache License 2.0
0 stars 0 forks source link

HW5 #6

Open zheleznov opened 4 years ago

zheleznov commented 4 years ago

Hello Kate.

Here some points on HW5

Task 1. Cards.

1. Content us not aligned at the center of the page 2. Arrow slightly diferrent from design arrow

3. BEM modifiers can't be used without module or elements classes. I mean for example just main--items is not correct. The right way is to use with block or element - main main--item bem

4. Two elements classes can't be in BEM. Two modules yes, but not 2 elements BEM2

Task 2. Menu

  1. Dropdown menu is not collapsed when i select sub menu item in it

  2. It's not good to use tag name in BEM CSS incorrect bem css

maslovakat commented 4 years ago

Thanks for your feedback! I have question, if I want to reset some styles for tags in the _reset.scss, I also can't use tag? And how would be better to perform it?

вт, 5 нояб. 2019 г., 21:13 Roman Zhelieznov notifications@github.com:

Hello Kate.

Here some points on HW5

Task 1. Cards.

1. Content us not aligned at the center of the page 2. Arrow slightly diferrent from design [image: arrow] https://user-images.githubusercontent.com/3533737/68237461-d4079e80-000f-11ea-8185-6082abcf3695.PNG

3. BEM modifiers can't be used without module or elements classes. I mean for example just main--items is not correct. The right way is to use with block or element - main main--item [image: bem] https://user-images.githubusercontent.com/3533737/68237745-68720100-0010-11ea-87ca-6c17042cb067.PNG

4. Two elements classes can't be in BEM. Two modules yes, but not 2 elements [image: BEM2] https://user-images.githubusercontent.com/3533737/68237748-6c058800-0010-11ea-9600-6c907b1f409d.PNG

Task 2. Menu

1.

Dropdown menu is not collapsed when i select sub menu item in it 2.

It's not good to use tag name in BEM CSS [image: incorrect bem css] https://user-images.githubusercontent.com/3533737/68237832-a53df800-0010-11ea-98aa-b14f0187257c.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maslovakat/epam_fe_2019_maslova/issues/6?email_source=notifications&email_token=AEDZKLEZFZY4FMO2BKJOAXDQSHAVHA5CNFSM4JJG4WR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HW7UA7A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZKLHTDEJDBZTJU4EDSHTQSHAVHANCNFSM4JJG4WRQ .

zheleznov commented 4 years ago

Thanks for your feedback! I have question, if I want to reset some styles for tags in the _reset.scss, I also can't use tag? And how would be better to perform it? вт, 5 нояб. 2019 г., 21:13 Roman Zhelieznov notifications@github.com: … Hello Kate. Here some points on HW5 Task 1. Cards. 1. Content us not aligned at the center of the page 2. Arrow slightly diferrent from design [image: arrow] https://user-images.githubusercontent.com/3533737/68237461-d4079e80-000f-11ea-8185-6082abcf3695.PNG 3. BEM modifiers can't be used without module or elements classes. I mean for example just main--items is not correct. The right way is to use with block or element - main main--item [image: bem] https://user-images.githubusercontent.com/3533737/68237745-68720100-0010-11ea-87ca-6c17042cb067.PNG 4. Two elements classes can't be in BEM. Two modules yes, but not 2 elements [image: BEM2] https://user-images.githubusercontent.com/3533737/68237748-6c058800-0010-11ea-9600-6c907b1f409d.PNG Task 2. Menu 1. Dropdown menu is not collapsed when i select sub menu item in it 2. It's not good to use tag name in BEM CSS [image: incorrect bem css] https://user-images.githubusercontent.com/3533737/68237832-a53df800-0010-11ea-98aa-b14f0187257c.PNG — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AEDZKLEZFZY4FMO2BKJOAXDQSHAVHA5CNFSM4JJG4WR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HW7UA7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZKLHTDEJDBZTJU4EDSHTQSHAVHANCNFSM4JJG4WRQ .

No no, in reset.css you can use tag. Reset css it's a separate entity and file and it's logic is to reset diferrent default browsers styles. Reset doesn't know anything about your html layout and what framework you want to use.

maslovakat commented 4 years ago

I understood, thanks!

вт, 5 нояб. 2019 г., 21:58 Roman Zhelieznov notifications@github.com:

Thanks for your feedback! I have question, if I want to reset some styles for tags in the reset.scss, I also can't use tag? And how would be better to perform it? вт, 5 нояб. 2019 г., 21:13 Roman Zhelieznov notifications@github.com: … <#m-4538929617636308930_> Hello Kate. Here some points on HW5 Task 1. Cards. 1. Content us not aligned at the center of the page 2. Arrow slightly diferrent from design [image: arrow] https://user-images.githubusercontent.com/3533737/68237461-d4079e80-000f-11ea-8185-6082abcf3695.PNG 3. BEM modifiers can't be used without module or elements classes. I mean for example just main--items is not correct. The right way is to use with block or element - main main--item [image: bem] https://user-images.githubusercontent.com/3533737/68237745-68720100-0010-11ea-87ca-6c17042cb067.PNG 4. Two elements classes can't be in BEM. Two modules yes, but not 2 elements [image: BEM2] https://user-images.githubusercontent.com/3533737/68237748-6c058800-0010-11ea-9600-6c907b1f409d.PNG *Task

  1. Menu* 1. Dropdown menu is not collapsed when i select sub menu item in it 2. It's not good to use tag name in BEM CSS [image: incorrect bem css] https://user-images.githubusercontent.com/3533737/68237832-a53df800-0010-11ea-98aa-b14f0187257c.PNG — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6 https://github.com/maslovakat/epam_fe_2019_maslova/issues/6?email_source=notifications&email_token=AEDZKLEZFZY4FMO2BKJOAXDQSHAVHA5CNFSM4JJG4WR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HW7UA7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZKLHTDEJDBZTJU4EDSHTQSHAVHANCNFSM4JJG4WRQ .

No no, in reset.css you can use tag. Reset css it's a separate entity and file and it's logic is to reset diferrent default browsers styles. Reset doesn't know anything about your html layout and what framework you want to use.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maslovakat/epam_fe_2019_maslova/issues/6?email_source=notifications&email_token=AEDZKLBJCGNNMNZ22CCM3MDQSHF6XA5CNFSM4JJG4WR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDEDZEI#issuecomment-549993617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZKLCCQAOB47BC6ZKISUTQSHF6XANCNFSM4JJG4WRQ .