masm11 / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
198 stars 14 forks source link

Failed to compile when enable PGTK_DEBUG #101

Closed declantsien closed 3 years ago

declantsien commented 3 years ago

I am trying to learn some GTK/C programming(All new to me BTW).

After I enable PGTK_DEBUG following here https://github.com/masm11/emacs#debugging, Emacs failed to compile.

Also, side question. Why gtk+3 not gtk4?

In file included from gtkutil.h:29,
                 from pgtkterm.c:43:
pgtkterm.c: In function ‘pgtk_set_window_size’:
pgtkterm.c:469:15: error: ‘pixelwise’ undeclared (first use in this function)
  469 |               pixelwise ? "pixel" : "char");
      |               ^~~~~~~~~
pgtkterm.h:47:67: note: in definition of macro ‘PGTK_TRACE’
   47 | e PGTK_TRACE(fmt, ...) pgtk_log(__FILE__, __LINE__, fmt, ## __VA_ARGS__)
      |                                                             ^~~~~~~~~~~

pgtkterm.c:469:15: note: each undeclared identifier is reported only once for each function it appears in
  469 |               pixelwise ? "pixel" : "char");
      |               ^~~~~~~~~
pgtkterm.h:47:67: note: in definition of macro ‘PGTK_TRACE’
   47 | e PGTK_TRACE(fmt, ...) pgtk_log(__FILE__, __LINE__, fmt, ## __VA_ARGS__)
      |                                                             ^~~~~~~~~~~

make[1]: *** [Makefile:388: pgtkterm.o] Error 1
masm11 commented 3 years ago

Thanks. I fixed the compile error.

Why gtk+3 not gtk4?

Because gtk4 was not stable when I started development.

declantsien commented 3 years ago

Nice. Confirmed it compiles.

So no plan to migrate to gtk4? I guess that's a lot of work. I am web developer, always pursue the latest version of a framework/library. Ha...

You are good to close this issue. Thanks.

masm11 commented 3 years ago

thanks for the confirmation.