search

masm11 / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
198 stars 14 forks source link

Empty new frame after disabled menu/scroll/tool bar #105

Closed declantsien closed 3 years ago

declantsien commented 3 years ago

Commands below should be enough to reproduce the issue

emacs -Q --eval "(scroll-bar-mode -1)" --eval "(menu-bar-mode -1)" --eval "(tool-bar-mode -1)" --eval "(make-frame-command)"

system-configuration-options

--with-pgtk --with-xft --with-wide-int --with-modules --with-cairo --with-harfbuzz 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now --with-native-compilation

Git commit hash https://github.com/emacs-mirror/emacs/tree/4b91168c657e3476b8a0a3f539ee6bcb1b71e3d5

https://i.imgur.com/PWJISwG.png

masm11 commented 3 years ago

Thank you for the speedy report. The issue is by the last two commits. I reverted them for now, and the issue should be gone.

declantsien commented 3 years ago

Cool. Ok to close this issue then.

masm11 commented 3 years ago

I re-applied the commits, debugged, and now this issue should be fixed. Could you confirm?

declantsien commented 3 years ago

Pulled the changes, compiled. And it works fine now. I confirm that the empty frame issue is gone. Nice work. :+1:

masm11 commented 3 years ago

Thanks.