masm11 / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
198 stars 14 forks source link

compilation error due to empty last case in switch #112

Closed collares closed 2 years ago

collares commented 2 years ago

The removal of the PGTK_TRACE call at https://github.com/emacs-mirror/emacs/blob/901938109f7b5574e97e787bee10441086680de8/src/pgtkterm.c#L4450 (in https://github.com/emacs-mirror/emacs/commit/901938109f7b5574e97e787bee10441086680de8) caused the following error:

pgtkterm.c: In function 'set_fullscreen_state':
pgtkterm.c:4278:10: error: label at end of compound statement
 4278 |     case FULLSCREEN_HEIGHT:
      |          ^~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:409: pgtkterm.o] Error 1
make[1]: Leaving directory '/build/source/src'
make: *** [Makefile:459: src] Error 2

Adding a break should be enough to fix it.

masm11 commented 2 years ago

Thanks. The issue seems to have been fixed.